Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken scripts/visual.sh #7095

Merged
merged 1 commit into from Jul 25, 2023
Merged

Fix broken scripts/visual.sh #7095

merged 1 commit into from Jul 25, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #7043 (where renaming happened)

Is there anything in the PR that needs further explanation?

This change fixes the following error. The correct path is bin/stylelint.mjs, not bin/stylelint.js.

$ ./scripts/visual.sh
...
node:internal/modules/cjs/loader:1051
  throw err;
  ^

Error: Cannot find module '/Users/masafumi.koba/git/stylelint/bin/stylelint.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
...

This change fixes the following error. The correct path is `bin/stylelint.mjs`, not `bin/stylelint.js`.

```console
$ ./scripts/visual.sh
...
node:internal/modules/cjs/loader:1051
  throw err;
  ^

Error: Cannot find module '/Users/masafumi.koba/git/stylelint/bin/stylelint.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
...
```
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

⚠️ No Changeset found

Latest commit: b1e1894

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ybiquitous ybiquitous marked this pull request as ready for review July 25, 2023 01:22
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@ybiquitous ybiquitous merged commit 0dbed54 into main Jul 25, 2023
18 checks passed
@ybiquitous ybiquitous deleted the fix-visual.sh branch July 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants