Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document security changelog group #7049

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Document security changelog group #7049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/maintainer-guide/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ When merging a PR, you should:
- one approval is usually fine for simple fixes
- two approvals are often useful for bigger changes
2. If applicable, add a [changeset](https://github.com/changesets/changesets) using the GitHub interface:
- prefix the entry with either: "Removed", "Changed", "Deprecated", "Added", or "Fixed"
- prefix the entry with either: "Removed", "Changed", "Deprecated", "Added", "Fixed" or "Security"
- if applicable, lead with the name of the rule, e.g. "Fixed: `unit-disallowed-list` false positives for custom properties".
3. ["Squash and merge"](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-merges#squash-and-merge-your-pull-request-commits) commits ensuring the resulting commit message:
- either matches the changeset entry but in the present tense, e.g. "Fix `unit-disallowed-list` false positives for custom properties"
Expand Down