Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom-property-pattern performance #7009

Merged
merged 3 commits into from Jun 30, 2023
Merged

Fix custom-property-pattern performance #7009

merged 3 commits into from Jun 30, 2023

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jun 30, 2023

Which issue, if any, is this issue related to?

Ref #6869

Is there anything in the PR that needs further explanation?

Before:
Mean: 148.86722335714288 ms
Deviation: 14.868270718260428 ms

After:
Mean: 120.50095842857144 ms
Deviation: 18.926086943302593 ms

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 3659a9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeddy3 jeddy3 changed the title Fix cpp p Fix custom-property-pattern performance Jun 30, 2023
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

I've left a suggestion, but it's minor.

lib/rules/custom-property-pattern/index.js Outdated Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 👍🏼

@jeddy3 jeddy3 merged commit 76a4648 into main Jun 30, 2023
18 checks passed
@jeddy3 jeddy3 deleted the fix-cpp-p branch June 30, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants