Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-element-no-unknown performance #7007

Merged
merged 2 commits into from Jun 30, 2023
Merged

Fix selector-pseudo-element-no-unknown performance #7007

merged 2 commits into from Jun 30, 2023

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jun 30, 2023

Which issue, if any, is this issue related to?

Ref #6869

Is there anything in the PR that needs further explanation?

Aborting as early as possible, i.e. before any isStandardSyntax* checks, helps too. I've added that as the third aspect of #6869 (comment).

Before:
Mean: 159.1181665714286 ms
Deviation: 18.599824916664016 ms

After:
Mean: 138.47696128571428 ms
Deviation: 16.776228134868457 ms

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 26c7b73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍🏼

@jeddy3 jeddy3 merged commit 518367a into main Jun 30, 2023
18 checks passed
@jeddy3 jeddy3 deleted the fix-spenu-p branch June 30, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants