Fix function-no-unknown performance #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f47c0d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jeddy3
changed the title
jeddy3
force-pushed
the
issue-6869-function-no-unknown
branch
from
94a4648
to
27e1591
Compare
ybiquitous
reviewed
Jun 30, 2023
There was a problem hiding this comment.
LGTM! How about adding a changelog entry like this?
Line 21 in 8051822
Oops, I'm rusty 😆 . I forgot to do that. |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6869
Before:
Mean: 104.89167158823528 ms
Deviation: 9.601897806542654 ms
After:
Mean: 71.84089116666665 ms
Deviation: 10.215987936599932 ms