Fix media-feature-name-no-unknown false positives for environment-blending, nav-controls, prefers-reduced-data, and video-color-gamut
#6978
Conversation
🦋 Changeset detectedLatest commit: 57fe5fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
LGTM!
Re:
The commit message and changelog entry still need to be changed to reflect this, but listing all four seemed verbose. Thoughts?
My initial thoughts are that listing all four seems reasonable, even if a bit verbose. I think this matches the style in our maintainer guide ("Fix x false positives/negatives for y").
Are these all missing for a reason (ex were only introduced recently)? Some of the past "false positives" changelog messages are a bit more generic, ex #3397
Fix level 5 media queries in media-feature-name-no-unknown
There was a problem hiding this comment.
Thanks, LGTM 👍🏼
I agree with @mattxwang:
My initial thoughts are that listing all four seems reasonable, even if a bit verbose.
If just Fixed: X false positives, people seeing the changelog may be confused.
romainmenke
changed the title
media-feature-name-no-unknown false positivesmedia-feature-name-no-unknown false positives for environment-blending, nav-controls, prefers-reduced-data and video-color-gamut
romainmenke
changed the title
media-feature-name-no-unknown false positives for environment-blending, nav-controls, prefers-reduced-data and video-color-gamutmedia-feature-name-no-unknown false positives for environment-blending, nav-controls, prefers-reduced-data, and video-color-gamut
…tives-for-environment-blending--considerate-boston-terrier-d8de21226f
romainmenke
deleted the
fix-media-feature-name-no-unknown-false-positives-for-environment-blending--considerate-boston-terrier-d8de21226f
branch
…blending`, `nav-controls`, `prefers-reduced-data`, and `video-color-gamut` (#6978) * Fix `media-feature-name-no-unknown` false positives * Create sharp-pans-whisper.md * Update sharp-pans-whisper.md * fmt
Closes #6968
I found 4 missing features:
environment-blendingnav-controlsprefers-reduced-datavideo-color-gamutThe commit message and changelog entry still need to be changed to reflect this, but listing all four seemed verbose. Thoughts?