Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-anb-no-unmatchable performance #6925

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/rules/selector-anb-no-unmatchable/index.js
Expand Up @@ -10,6 +10,7 @@ const isStandardSyntaxRule = require('../../utils/isStandardSyntaxRule');
const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const validateOptions = require('../../utils/validateOptions');
const hasANPlusBNotationPseudoClasses = require('../../utils/hasANPlusBNotationPseudoClasses');

const ruleName = 'selector-anb-no-unmatchable';

Expand Down Expand Up @@ -50,6 +51,8 @@ const rule = (primary) => {
}

ruleNode.selectors.forEach((selector) => {
if (!hasANPlusBNotationPseudoClasses(selector)) return;

let cssTreeSelector;

try {
Expand Down
24 changes: 24 additions & 0 deletions lib/utils/hasANPlusBNotationPseudoClasses.js
@@ -0,0 +1,24 @@
'use strict';

const {
aNPlusBNotationPseudoClasses,
aNPlusBOfSNotationPseudoClasses,
} = require('../reference/selectors');

const HAS_A_N_PLUS_B_NOTATION_PSEUDO_CLASSES = new RegExp(
`\\b:(?:${[
...aNPlusBNotationPseudoClasses.values(),
...aNPlusBOfSNotationPseudoClasses.values(),
].join('|')})\\(`,
'i',
);
romainmenke marked this conversation as resolved.
Show resolved Hide resolved

/**
* Check if a selector contains any pseudo class function that might contain an An+B notation
*
* @param {string} selector
* @returns {boolean}
*/
module.exports = function hasANPlusBNotationPseudoClasses(selector) {
return HAS_A_N_PLUS_B_NOTATION_PSEUDO_CLASSES.test(selector);
};