Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function-linear-gradient-no-nonstandard-direction performance #6924

Merged
merged 3 commits into from Jun 17, 2023
Merged

Fix function-linear-gradient-no-nonstandard-direction performance #6924

merged 3 commits into from Jun 17, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 16, 2023 •
edited

Which issue, if any, is this issue related to?

See #6869

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

before :

Warnings: 0
Mean: 89.20350494117648 ms
Deviation: 11.294021704297947 ms

after :

Warnings: 0
Mean: 77.0127245 ms
Deviation: 7.537474958126632 ms

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023 •
edited

🦋 Changeset detected

Latest commit: 9a45d54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

romainmenke and others added 2 commits June 17, 2023 10:03
@romainmenke @ybiquitous
apply suggestions from code review
097de2b 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@romainmenke
Create popular-cougars-build.md
9a45d54
ybiquitous
ybiquitous approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your commitment to performance improvement! 👏🏼

@romainmenke romainmenke merged commit f72a6a9 into main Jun 17, 2023
18 checks passed
@romainmenke romainmenke deleted the fix-function-linear-gradient-no-nonstandard-direction-performance--persistent-giant-schnauzer-646b367c04 branch June 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouvedia Mouvedia Mouvedia left review comments

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romainmenke @Mouvedia @ybiquitous