Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media-feature-name-value-no-unknown #6906

Merged
merged 21 commits into from Jun 13, 2023
Merged

Add media-feature-name-value-no-unknown #6906

merged 21 commits into from Jun 13, 2023

Commits on Jun 4, 2023

  1. wip

    @romainmenke
    romainmenke committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    ed083d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge remote-tracking branch 'origin/main' into add-media-feature-nam… 

    …e-value-no-unknown--witty-south-china-tiger-8b25eed791
    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    31f12b6 View commit details
    Browse the repository at this point in the history

  2. first working draft

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    fb89f3a View commit details
    Browse the repository at this point in the history

  3. Create real-dingos-boil.md

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    05bbd4d View commit details
    Browse the repository at this point in the history

  4. note 1

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6d7d1f7 View commit details
    Browse the repository at this point in the history

  5. increase test coverage

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2614749 View commit details
    Browse the repository at this point in the history

  6. increase coverage

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    c7ba8e4 View commit details
    Browse the repository at this point in the history

  7. increase test coverage

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    968fd3a View commit details
    Browse the repository at this point in the history

  8. cleanup

    @romainmenke
    romainmenke committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    6a1fb83 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'main' into add-media-feature-name-value-no-unknown--wit… 

    …ty-south-china-tiger-8b25eed791
    @romainmenke
    romainmenke committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    7ef6767 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. improve code comments

    @romainmenke
    romainmenke committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    d64cce8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-media-feature-name-value-no-unknown--wit… 

    …ty-south-china-tiger-8b25eed791
    @romainmenke
    romainmenke committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    bc2833a View commit details
    Browse the repository at this point in the history

  3. cleanup and a few more tests

    @romainmenke
    romainmenke committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    ad00a17 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. increase test coverage

    @romainmenke
    romainmenke committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    25436d3 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @romainmenke @ybiquitous
    romainmenke and ybiquitous committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    d989f24 View commit details
    Browse the repository at this point in the history

  3. Update lib/rules/media-feature-name-value-no-unknown/index.js 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @romainmenke @ybiquitous
    romainmenke and ybiquitous committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    0f6cfe4 View commit details
    Browse the repository at this point in the history

  4. Update lib/rules/media-feature-name-value-no-unknown/index.js 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @romainmenke @ybiquitous
    romainmenke and ybiquitous committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    76c88fa View commit details
    Browse the repository at this point in the history

  5. apply suggestions from code review

    @romainmenke
    romainmenke committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ce1cdf2 View commit details
    Browse the repository at this point in the history

  6. refactor : add resolutionUnits to reference/units

    @romainmenke
    romainmenke committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a0e9404 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Update lib/reference/units.js 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @romainmenke @ybiquitous
    romainmenke and ybiquitous committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dc3b4a2 View commit details
    Browse the repository at this point in the history

  2. fix endIndex offset

    @romainmenke
    romainmenke committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    85a24c9 View commit details
    Browse the repository at this point in the history