New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to migrate unit-disallowed-list
to new media query parser
#6886
Refactor to migrate unit-disallowed-list
to new media query parser
#6886
Conversation
|
bf402ae
to
9b6f395
Compare
unit-disallowed-list
to new media query parser
…ne-toad-1e26e5f4ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romainmenke Thanks for the pull request! This is almost good. But could you confirm my reviews, please?
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
16886da
to
f807664
Compare
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
This also requires a check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
Thank you for all the reviews @ybiquitous 🙇 |
See : #6848
No, it's self-explanatory.