New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit-no-unknown
false positives for the second and subsequent image-set()
with x
descriptor
#6879
Fix unit-no-unknown
false positives for the second and subsequent image-set()
with x
descriptor
#6879
Conversation
🦋 Changeset detectedLatest commit: d453ed1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…tive-emperor-tamarin-9e7856b2d6
@ybiquitous I intended to just change the parser here, but this change also had the side effect of fixing an issue. I propose changing the title and adding the correct changelog for that: Fix `unit-no-unknown` false positives for the second and subsequent `image-set()` with `x` descriptor I would also add |
Yes, that's a good idea on #6879 (comment) Please update them! |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
unit-no-unknown
to new media query parserunit-no-unknown
false positives for the second and subsequent image-set()
with x
descriptor
Co-authored-by: Takuya Fukuju <chalkygames123@gmail.com>
…r-tamarin-9e7856b2d6' of https://github.com/stylelint/stylelint into migrate-unit-no-unknown-to-new-parser--inventive-emperor-tamarin-9e7856b2d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
See : #6848
Supersedes : #6726
this will fail because it uses unreleased features of the media query parserunit-no-unknown
false positives for the second and subsequentimage-set()
withx
descriptor #6726before :
after :