Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit-no-unknown false positives for the second and subsequent image-set() with x descriptor #6879

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented May 31, 2023

Which issue, if any, is this issue related to?

See : #6848
Supersedes : #6726

Is there anything in the PR that needs further explanation?

before :

npm run benchmark-rule unit-no-unknown true
Warnings: 0
Mean: 143.3089323125 ms
Deviation: 10.593647978441565 ms

after :

npm run benchmark-rule unit-no-unknown true
Warnings: 0
Mean: 109.86287500000002 ms
Deviation: 9.320724134887374 ms

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: d453ed1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@romainmenke
Copy link
Member Author

@ybiquitous I intended to just change the parser here, but this change also had the side effect of fixing an issue.

I propose changing the title and adding the correct changelog for that:

Fix `unit-no-unknown` false positives for the second and subsequent `image-set()` with `x` descriptor

I would also add chalkygames123 as a co-author as they wrote the tests that I used to verify the fix in #6726

@romainmenke romainmenke marked this pull request as ready for review June 1, 2023 15:24
@mattxwang mattxwang mentioned this pull request Jun 1, 2023
4 tasks
@ybiquitous
Copy link
Member

Yes, that's a good idea on #6879 (comment)

Please update them!

lib/rules/unit-no-unknown/index.js Show resolved Hide resolved
lib/rules/unit-no-unknown/index.js Outdated Show resolved Hide resolved
romainmenke and others added 3 commits June 2, 2023 10:21
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@romainmenke romainmenke changed the title Refactor to migrate unit-no-unknown to new media query parser Fix unit-no-unknown false positives for the second and subsequent image-set() with x descriptor Jun 2, 2023
romainmenke and others added 4 commits June 2, 2023 10:29
Co-authored-by: Takuya Fukuju <chalkygames123@gmail.com>
…r-tamarin-9e7856b2d6' of https://github.com/stylelint/stylelint into migrate-unit-no-unknown-to-new-parser--inventive-emperor-tamarin-9e7856b2d6
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@romainmenke romainmenke merged commit 7206cfc into main Jun 2, 2023
14 checks passed
@romainmenke romainmenke deleted the migrate-unit-no-unknown-to-new-parser--inventive-emperor-tamarin-9e7856b2d6 branch June 2, 2023 09:39
@ScorpAL

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit-no-unknown false positives for the second and subsequent image-set() with x descriptor
3 participants