Fix at-rule-property-required-list performance

[romainmenke]

Which issue, if any, is this issue related to?

See:

• [parser] Implement full featured CSS parser css-parser#2
• Fix performance of constructor parsing rules #6869

Is there anything in the PR that needs further explanation?

In this at-rule-property-required-list two types of work were less than ideal :

• formatting of plugin options
• nested loops

[changeset-bot]

🦋 Changeset detected

Latest commit: f007bb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ybiquitous]

Benchmark on my local machine

M1 MacBook Pro / Node.js v20.2.0

npm run benchmark-rule -- at-rule-property-required-list '{"font-face": ["font-display", "font-family", "font-style"], "page": "margin"}'

Before

Warnings: 20
Mean: 81.61474988235294 ms
Deviation: 6.212360461737067 ms

After

Warnings: 20
Mean: 82.71980147058825 ms
Deviation: 11.136367856858897 ms

[romainmenke]

Yeah, the difference is very small.
There is only a single @page rule in the benchmark source, no @font-face rules.

I am fine with dropping this change.

I also tested with something that has more hits and even then it isn't clear which is faster :

node scripts/benchmark-rule.mjs at-rule-property-required-list { "media": ["width", "height"] }

[ybiquitous]

No problems. Thank you for creating this pull request! 👍🏼

Even if the improvement is small, the new code is more readable and adds a new utility to be able to improve other rules.