Fix string formatter for unexpected truncation on non-ASCII characters
#6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a01eae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This may be the same problem as gajus/table#180 |
ybiquitous
requested changes
May 24, 2023
ybiquitous
changed the title
stringFormatter unexpected truncation on non-ascii charactersstring formatter for unexpected truncation on non-ascii characters
ybiquitous
changed the title
string formatter for unexpected truncation on non-ascii charactersstring formatter for unexpected truncation on non-ASCII characters
OK， thanks for your review，i will refactor it soon～ |
…aracter class escape` & cache `getMessageWidth` result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issus: stringFormatter.js truncate non-ASCII characters unexpectedly
Closes #6860
The reason that why don't I just contribute code to repository
table, is: make it to support full ability about non-ASCII seems like a lot of work. before it, we can solve the problem in this way first。