Fix declaration-block-no-redundant-longhand-properties autofix for transition
#6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a396db5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
requested changes
Apr 26, 2023
There was a problem hiding this comment.
@mattxwang Thanks for the pull request! Please consider addressing my reviews (mainly refactoring).
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
… a fix case for `none` of size 1
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…ndex.js Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
So sorry for the rushed PR, I got sidetracked (in-person) in the middle of finishing it up - meant to mark it as draft 😅 . Hopefully it wasn't too frustrating to review! I think I've addressed all of the comments (and slightly changed my approach re: the |
mattxwang
commented
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6812.
This one required some non-trivial CSS spec reading, hence the complicated-ish behaviour!