Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *-no-redundant-* false negatives for inset shorthand #6699

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

rayrw
Copy link
Contributor

@rayrw rayrw commented Mar 7, 2023

Closes #6613

This PR updates these 2 rules to support the inset property

  • declaration-block-no-redundant-longhand-properties
  • shorthand-property-no-redundant-values

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

🦋 Changeset detected

Latest commit: 95e24f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rayrw rayrw changed the title Fix declaration-block-no-redundant-longhand-properties false negatives for inset shorthand Fix false negatives for inset property shorthand Mar 8, 2023
@rayrw rayrw marked this pull request as ready for review March 8, 2023 01:50
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rayrw Thanks for the pull request. Almost LGTM, but I've left several comments about the code style. Could you please consider addressing them?

lib/reference/properties.js Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Outdated Show resolved Hide resolved
@rayrw rayrw requested a review from ybiquitous March 8, 2023 05:09
@rayrw
Copy link
Contributor Author

rayrw commented Mar 8, 2023

@ybiquitous Thanks for the reviews!
I've applied your suggestions in f017239

@ybiquitous ybiquitous changed the title Fix false negatives for inset property shorthand Fix declaration-block-no-redundant-longhand-properties and shorthand-property-no-redundant-values false negatives for inset shorthand Mar 8, 2023
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! LGTM 👍🏼

@jeddy3 jeddy3 changed the title Fix declaration-block-no-redundant-longhand-properties and shorthand-property-no-redundant-values false negatives for inset shorthand Fix *-no-redundant-* false negatives for inset shorthand Mar 8, 2023
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thanks for making the title and changelog much simpler! 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix declaration-block-no-redundant-longhand-properties false negatives for inset shorthand
3 participants