Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to add parse media query list util #6585

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Refactor to add parse media query list util #6585

merged 1 commit into from
Jan 22, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jan 19, 2023 •
edited

Which issue, if any, is this issue related to?

This adds the utility for media query parsing.

Fixes : #6559

Is there anything in the PR that needs further explanation?

I've also update the packages relevant to media query parsing.
This includes some bug fixes and a simpler API for common actions.

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

⚠️ No Changeset found

Latest commit: 87cacc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeddy3 jeddy3 changed the title parse media query list util Refactor to add parse media query list util Jan 20, 2023
jeddy3
jeddy3 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ybiquitous ybiquitous linked an issue Jan 22, 2023 that may be closed by this pull request
Refactor to include parseMediaQuery util for @csstools/media-query-list-parser #6559
Closed
ybiquitous
ybiquitous approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍🏼

@ybiquitous ybiquitous merged commit a7350c6 into stylelint:v15 Jan 22, 2023
@ybiquitous ybiquitous mentioned this pull request Jan 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor to include parseMediaQuery util for @csstools/media-query-list-parser
3 participants
@romainmenke @ybiquitous @jeddy3