Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function-calc-no-unspaced-operator performance #6923

Merged
merged 3 commits into from Jun 17, 2023
Merged

Fix function-calc-no-unspaced-operator performance #6923

merged 3 commits into from Jun 17, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 16, 2023 •
edited

Which issue, if any, is this issue related to?

See : #6869

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

before :

Warnings: 0
Mean: 90.56110877777778 ms
Deviation: 11.54085198893875 ms

after :

Warnings: 0
Mean: 83.60294444444445 ms
Deviation: 10.305877029720664 ms

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023 •
edited

🦋 Changeset detected

Latest commit: d647e47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@romainmenke @ybiquitous
Update lib/rules/function-calc-no-unspaced-operator/index.js
a6a8050 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@romainmenke

This comment was marked as outdated.

Sign in to view
@romainmenke romainmenke force-pushed the fix-function-calc-no-unspaced-operator-performance--intuitive-woodlouse-8922922016 branch from 9face2e to d647e47 Compare June 17, 2023 07:48
ybiquitous
ybiquitous approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

@romainmenke romainmenke merged commit 0e4d302 into main Jun 17, 2023
18 checks passed
@romainmenke romainmenke deleted the fix-function-calc-no-unspaced-operator-performance--intuitive-woodlouse-8922922016 branch June 17, 2023 08:32
@ybiquitous ybiquitous mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainmenke @ybiquitous