Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to migrate unit-disallowed-list to new media query parser #6886

Merged
merged 10 commits into from Jun 5, 2023
Merged

Refactor to migrate unit-disallowed-list to new media query parser #6886

merged 10 commits into from Jun 5, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 3, 2023 •
edited

Which issue, if any, is this issue related to?

See : #6848

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2023 •
edited

⚠️ No Changeset found

Latest commit: 184fbd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@romainmenke romainmenke force-pushed the migrate-unit-disallowed-list--impartial-marine-toad-1e26e5f4ca branch from bf402ae to 9b6f395 Compare June 3, 2023 10:08
@romainmenke romainmenke changed the title Refactor to migrate to new media query parser Refactor to migrate unit-disallowed-list to new media query parser Jun 3, 2023
ybiquitous
ybiquitous reviewed Jun 3, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romainmenke Thanks for the pull request! This is almost good. But could you confirm my reviews, please?

lib/rules/unit-disallowed-list/index.js Outdated Show resolved Hide resolved
lib/rules/unit-disallowed-list/index.js Outdated Show resolved Hide resolved
lib/rules/unit-disallowed-list/index.js Outdated Show resolved Hide resolved
romainmenke and others added 4 commits June 3, 2023 17:31
@romainmenke romainmenke force-pushed the migrate-unit-disallowed-list--impartial-marine-toad-1e26e5f4ca branch from 16886da to f807664 Compare June 3, 2023 16:54
romainmenke and others added 2 commits June 4, 2023 09:53
@romainmenke @ybiquitous
Update lib/rules/unit-disallowed-list/index.js
66c4ad5 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@romainmenke
cleanup
5134196
@romainmenke
Copy link
Member Author

This also requires a check for <urange>.
See : #6892

ybiquitous
ybiquitous approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

@romainmenke
Copy link
Member Author

Thank you for all the reviews @ybiquitous 🙇

@romainmenke romainmenke merged commit f1ace61 into main Jun 5, 2023
14 checks passed
@romainmenke romainmenke deleted the migrate-unit-disallowed-list--impartial-marine-toad-1e26e5f4ca branch June 5, 2023 08:04
@romainmenke romainmenke mentioned this pull request Jun 5, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainmenke @ybiquitous