New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaration-block-no-redundant-longhand-properties
autofix for transition
#6815
Conversation
🦋 Changeset detectedLatest commit: a396db5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thanks for the pull request! Please consider addressing my reviews (mainly refactoring).
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
… a fix case for `none` of size 1
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
…ndex.js Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
So sorry for the rushed PR, I got sidetracked (in-person) in the middle of finishing it up - meant to mark it as draft 😅 . Hopefully it wasn't too frustrating to review! I think I've addressed all of the comments (and slightly changed my approach re: the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
Closes #6812.
This one required some non-trivial CSS spec reading, hence the complicated-ish behaviour!