Skip to content

Commit

Permalink
cleanup and a few more tests
Browse files Browse the repository at this point in the history
  • Loading branch information
romainmenke committed Jun 10, 2023
1 parent bc2833a commit ad00a17
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 10 deletions.
17 changes: 17 additions & 0 deletions lib/rules/media-feature-name-value-no-unknown/__tests__/index.js
Expand Up @@ -71,6 +71,14 @@ testRule({
code: '@media screen and (min-width: env(some-width-variable)) and (hover: env(some-width-variable)) and (aspect-ratio < env(some-number-variable) / 100) {}',
description: 'Environment variables',
},
{
code: '@media (-webkit-hover: -webkit-hover) {}',
description: 'Double vendor prefixes when valid',
},
{
code: '@media (foo: 100px) {}',
description: 'Unknown media feature',
},
],

reject: [
Expand Down Expand Up @@ -101,6 +109,15 @@ testRule({
endLine: 1,
endColumn: 42,
},
{
code: '@media (-webkit-hover: -webkit-pointer) {}',
description: 'Double vendor prefixes when invalid',
message: messages.rejected('-webkit-hover', '-webkit-pointer'),
line: 1,
column: 24,
endLine: 1,
endColumn: 38,
},
{
code: '@media (color: 1.1) {}',
description: 'Float value when only integers are allowed',
Expand Down
21 changes: 11 additions & 10 deletions lib/rules/media-feature-name-value-no-unknown/index.js
@@ -1,25 +1,26 @@
'use strict';

const atRuleParamIndex = require('../../utils/atRuleParamIndex');
const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const validateOptions = require('../../utils/validateOptions');
const vendor = require('../../utils/vendor');
const parseMediaQuery = require('../../utils/parseMediaQuery');
const { TokenType, NumberType } = require('@csstools/css-tokenizer');
const { isTokenNode, isFunctionNode } = require('@csstools/css-parser-algorithms');
const {
isMediaFeature,
isMediaFeatureValue,
matchesRatioExactly,
} = require('@csstools/media-query-list-parser');
const { isTokenNode, isFunctionNode } = require('@csstools/css-parser-algorithms');
const { TokenType, NumberType } = require('@csstools/css-tokenizer');

const atRuleParamIndex = require('../../utils/atRuleParamIndex');
const parseMediaQuery = require('../../utils/parseMediaQuery');
const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const validateOptions = require('../../utils/validateOptions');
const vendor = require('../../utils/vendor');
const { lengthUnits } = require('../../reference/units');
const { mathFunctions } = require('../../reference/functions');
const {
mediaFeatureNameAllowedValueKeywords,
mediaFeatureNameAllowedValueTypes,
mediaFeatureNames,
} = require('../../reference/mediaFeatures');
const { lengthUnits } = require('../../reference/units');
const { mathFunctions } = require('../../reference/functions');

const ruleName = 'media-feature-name-value-no-unknown';

Expand Down

0 comments on commit ad00a17

Please sign in to comment.