Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsetohsl): fixes support for 4 space-separated CSS values #606

Merged
merged 3 commits into from
Apr 3, 2022

Conversation

bhough
Copy link
Contributor

@bhough bhough commented Apr 1, 2022

fix #605

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #606 (9f90463) into main (bf2bd28) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #606   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           89        89           
  Lines          856       856           
  Branches       319       319           
=========================================
  Hits           856       856           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/color/transparentize.js 100.00% <ø> (ø)
src/color/parseToRgb.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2bd28...9f90463. Read the comment docs.

@bhough bhough merged commit f35d317 into main Apr 3, 2022
@bhough bhough deleted the parse-hsl-fix branch April 3, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseToHsl Doesn't seem to parse valid CSS Colors 4 space-separated values
2 participants