Beta: better support for trio in HTTPClientAsync #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-async-more-compatible
branch
from
d92e8b3
to
ca1543d
Compare
richardm-stripe
force-pushed
the
richardm-async-more-compatible
branch
from
2ab932d
to
fa7871a
Compare
richardm-stripe
changed the title
richardm-stripe
changed the title
richardm-stripe
requested review from
a team and
pakrym-stripe
and removed request for
a team
pakrym-stripe
approved these changes
Jan 26, 2024
richardm-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
trioon HttpClientAsync.Details
Acts on suggestions by @Zac-HD on #327 (comment).
anyiomodule be available alongsidehttpxas a prerequisite for using the async HTTPX client. HTTPX has a dependency on anyio anyway, so there is no downside to this.asyncio.sleeptoanyio.sleep-- this means that users oftrioandasynciowill both be able to use the httpx client without any additional configuration.asyncioandtriobackends. This is accomplished by adding thepytest.mark.anyiomarker on all the asynchronous tests (where previously I was using the pytest-asyncio marker). The pytest integration comes bundled in withanyio(which I have added to the test dependencies), and is described at https://anyio.readthedocs.io/en/stable/testing.html. The default behavior of this marker is to run everything on all supported backends (so both asyncio and trio). I can confirm that tests are indeed running with trio, because I had errors when I only didpip install anyioinstead ofpip install anyio[trio].