Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite: fix subtest names (fix #1501) #1504

Merged
merged 2 commits into from Nov 9, 2023
Merged

Commits on Nov 1, 2023

  1. suite: fix TestSubtestPanic failure (#1501)

    The subtest of TestSubtestPanic is expected to fail, but that must not
    make the testuite of package 'suite' to fail. So call Skip to make 'go
    test' to ignore that expected failure.
    dolmen committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6868057 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. suite: fix subtests names

    We are doing dirty things with testing.InternalTest. It looks like test
    names should have the same prefix as the parent test, like if they were
    true subtests (testing.T.Run).
    
    So until we drop our usage of testing.InternamTest, let's rename the
    tests.
    
    Also added a few checks of the testing.RunTests result.
    dolmen committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d25f6e4 View commit details
    Browse the repository at this point in the history