Ensure AssertExpectations does not fail in skipped tests

[ianrose14]

Summary

Prevent (*Mock).AssertExpectations from failing if test expectations are not met but the test has already been marked as "Skipped".

Changes

• Add check to (*Mock).AssertExpectations such that if the *testing.T is already marked skipped, we just return true immediately.
• Add a unit test (Test_Mock_AssertExpectations_Skipped_Test) for the new behavior.

Motivation

Normally the decision to skip a test is made early in the test function, but on occasion it might be the case that you have already set up some mock expectations before you call t.Skip. If that's the case, then a call to AssertExpectations will fail, which is not intended.

Example usage (if applicable)

func TestExample(t *testing.T) {
	val := new(MockedValue)
	val.On("DoThing", 1, 2).Return(3, 4)
	defer val.AssertExpectations(t)

	if os.GetEnv("foo") == "" {
		// This will cause the test to exit, which will run the deferred AssertExpections call above
		t.Skip("nevermind")
	}
	...
}

Related issues

Closes #1329

[brackendawson]

Thanks for the PR, I'd love to see this merged.

[dolmen]

@ianrose14 Could you rebase your branch on top of master (and fix conflicts)?

[ianrose14]

@ianrose14 Could you rebase your branch on top of master (and fix conflicts)?

done!

[ianrose14]

@dolmen Can you re-review this please? I've resolved merge conflicts.

[dolmen]

Code looks good.

Please squash commits.

[ianrose14]

Code looks good.

Please squash commits.

@dolmen done!

[brackendawson]

Thank you for your contribution.