Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in comments and tests #1247

Merged
merged 1 commit into from Feb 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Expand Up @@ -14,10 +14,10 @@ assignees: ''
<!-- A detailed description of the bug -->

## Step To Reproduce
<!-- Steps or code snippet to reproduce the behaviour -->
<!-- Steps or code snippet to reproduce the behavior -->

## Expected behaviour
## Expected behavior
<!-- A clear and concise description of what you expected to happen -->

## Actual behaviour
## Actual behavior
<!-- What testify does -->
2 changes: 1 addition & 1 deletion assert/assertions_test.go
Expand Up @@ -880,7 +880,7 @@ func TestNotEqualValues(t *testing.T) {
{new(AssertionTesterConformingObject), new(AssertionTesterConformingObject), false},
{&struct{}{}, &struct{}{}, false},

// Different behaviour from NotEqual()
// Different behavior from NotEqual()
{func() int { return 23 }, func() int { return 24 }, true},
{int(10), int(11), true},
{int(10), uint(10), false},
Expand Down
14 changes: 7 additions & 7 deletions suite/suite_test.go
Expand Up @@ -21,7 +21,7 @@ import (
type SuiteRequireTwice struct{ Suite }

// TestSuiteRequireTwice checks for regressions of issue #149 where
// suite.requirements was not initialised in suite.SetT()
// suite.requirements was not initialized in suite.SetT()
// A regression would result on these tests panicking rather than failing.
func TestSuiteRequireTwice(t *testing.T) {
ok := testing.RunTests(
Expand Down Expand Up @@ -693,23 +693,23 @@ func TestSubtestPanic(t *testing.T) {
assert.True(t, suite.inTearDownSuite)
}

type unInitialisedSuite struct {
type unInitializedSuite struct {
Suite
}

// TestUnInitialisedSuites asserts the behaviour of the suite methods when the
// suite is not initialised
func TestUnInitialisedSuites(t *testing.T) {
// TestUnInitializedSuites asserts the behavior of the suite methods when the
// suite is not initialized
func TestUnInitializedSuites(t *testing.T) {
t.Run("should panic on Require", func(t *testing.T) {
suite := new(unInitialisedSuite)
suite := new(unInitializedSuite)

assert.Panics(t, func() {
suite.Require().True(true)
})
})

t.Run("should panic on Assert", func(t *testing.T) {
suite := new(unInitialisedSuite)
suite := new(unInitializedSuite)

assert.Panics(t, func() {
suite.Assert().True(true)
Expand Down