Skip to content

Commit

Permalink
ci: Remove eslint-plugin-promise (#2076)
Browse files Browse the repository at this point in the history
* ci: Remove eslint-plugin-promise

Add it back when [Support ESLint 8.x · Issue #218 · xjamundx/eslint-plugin-promise](eslint-community/eslint-plugin-promise#218) is resolved.
  • Loading branch information
Jason3S committed Dec 7, 2021
1 parent 5b63535 commit df247c7
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const config = {
'plugin:node/recommended',
'plugin:import/errors',
'plugin:import/warnings',
'plugin:promise/recommended',
// 'plugin:promise/recommended',
'plugin:prettier/recommended',
],
ignorePatterns: [
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/src/check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ function asPendingPromise<T>(promise: Promise<T>): PendingPromise<T> {
state: 'pending',
};

// eslint-disable-next-line promise/catch-or-return
// x-eslint-disable-next-line promise/catch-or-return
promise.then(
(v) => ((pp.state = 'resolved'), v),
(r) => ((pp.state = 'rejected'), r)
Expand Down
20 changes: 0 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"eslint-plugin-jest": "^25.3.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-promise": "^5.2.0",
"globcat": "^2.0.0",
"jest": "^27.4.0",
"lerna": "^4.0.0",
Expand Down

0 comments on commit df247c7

Please sign in to comment.