fix(client): Resume after gap fill error #1570
Merged
+77
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbu
approved these changes
Jun 21, 2023
teogeb
added a commit
that referenced
this pull request
Jun 22, 2023
When an error occurs in message ordering, the `OrderedMsgChain` calls an `onError` callback which is registered by the `OrderMessages` class. There is a parameter in that call, but `OrderMessages` doesn't use the value. See https://github.com/streamr-dev/network/blob/73b83c0cc2af716a3b09c71f13cb05665cee25fe/packages/client/src/subscribe/OrderMessages.ts#L51 Refactored error handler to be just a callback without arguments and removed the custom `GapFillFailedError` class. ### Open questions In PR #1570 we changed the error handling functionality so that the pipeline can continue to process messages after error. There we consider the error case as an empty result. But if we want we could notify subscription somehow if there is an error. If we want to notify, should we emit error only when there is a storage node error, or maybe also when we can't fill the gap (i.e. don't find the missing messages from the storage node). See: https://github.com/streamr-dev/network/blob/73b83c0cc2af716a3b09c71f13cb05665cee25fe/packages/client/test/unit/OrderedMsgChain.test.ts#L429 - If we want to notify the subscription, we should use `StreamrClientError` instead of custom `GapFillFailedError` - It currently not possible to add error listeners for resend streams (i.e. when user calls `StreamrClient#resend()`)
samt1803
added a commit
that referenced
this pull request
Jun 27, 2023
…nto nodeInspectionFlagService * origin/NET-953-tatum-miner-framework: (29 commits) Refactor operator plugin (#1575) NET-527 maintain operator value service (#1513) build(deps): Bump @typescript-eslint/parser from 5.59.11 to 5.60.1 (#1603) build(deps): Bump @snapshot-labs/snapshot.js from 0.4.99 to 0.4.100 (#1596) build(deps-dev): Bump electron from 25.1.1 to 25.2.0 (#1597) build(deps): Bump tsyringe from 4.7.0 to 4.8.0 (#1598) build(deps): Bump @typescript-eslint/eslint-plugin from 5.59.11 to 5.60.0 (#1600) build(deps-dev): Bump nightwatch from 2.6.21 to 3.0.1 (#1601) build(deps-dev): Bump webpack from 5.87.0 to 5.88.0 (#1602) release(client, cli-tools): v8.5.4 Docs (#1591) refactor(client): Remove `GapFillFailedError` (#1579) feat(client): Abort resends when `OrderMessages` stops (#1571) fix(client): Resume after gap fill error (#1570) test(client): Unit tests for resend subscription (#1569) build(deps): Bump eslint from 8.42.0 to 8.43.0 (#1560) build(deps): Bump commander from 10.0.1 to 11.0.0 (#1559) build(deps): Bump semver from 7.5.1 to 7.5.2 (#1562) feat(client): Informative error messages for contract call errors (#1558) fix(client): Error handling of `fetchHttpStream` (#1554) ... # Conflicts: # packages/broker/.vscode/launch.json # packages/broker/package.json # packages/broker/src/plugins/operator/FakeOperatorClient.ts # packages/broker/src/plugins/operator/MaintainTopologyHelper.ts # packages/broker/src/plugins/operator/MaintainTopologyService.ts # packages/broker/src/plugins/operator/OperatorPlugin.ts # packages/broker/test/integration/plugins/operator/MaintainTopologyHelper.test.ts # packages/broker/test/integration/plugins/operator/MaintainTopologyService.test.ts # packages/broker/test/integration/plugins/operator/smartContractUtils.ts # packages/broker/test/unit/plugins/operator/MaintainTopologyService.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If storage node responds with an error, it is considered as en empty response.
Before this PR the pipeline stopped to process any subsequent messages for the subscription (including all real-time messages which we'd receive in the future) if there was a storage node error.
The output stream was closed here:
network/packages/client/src/subscribe/OrderMessages.ts
Line 97 in 72e4a79
See also this TODO:
network/packages/client/src/subscribe/OrderMessages.ts
Line 52 in 72e4a79
The
endWrite(err)call was added in this commit: d07be0eFuture improvements