fix: remove double conversion that causes date shift #22410

butcherZ · 2024-12-12T19:18:36Z

What does it do?

removed the convertLocalDateToUTCDate function which caused double conversion and date shift from the client side (check the video posted in #22023 ), the component now preserves the actual calendar date the user selected and eliminates timezone-related shifts (same behaviours as in V4)

Why is it needed?

by default, Date object will be created in the local time zone of the user's browser, but dates should be kept consistent in UTC at all times

How to test it?

launch examples/getStarted
change your device's timezone to PST (Los Angeles for example )
go to content type builder, create a collection with a date field
go to content manager, create a new entry
please check:
1. When selecting a date from a date picker, the date displayed in the input is the selected value.
2. Without selecting the date, if the datePicker loses focus (onBlur), the date shown in the input is not changing.
save the new entry, and change the timezone on your device again (to Singapore for example)
the displayed date doesn't change its value
change back the timezone and verify the value again.

Related issue(s)/PR(s)

fixes #22023

DX-1788

vercel · 2024-12-12T19:18:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
contributor-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 17, 2024 2:25pm

trunk-io · 2024-12-12T20:39:42Z

_{View Full Report ↗︎ ⋅ Docs}

remidej · 2024-12-13T08:21:20Z

packages/core/admin/admin/src/components/FormInputs/Date.tsx

@@ -1,6 +1,5 @@
-import { forwardRef, memo } from 'react';
+import { forwardRef, memo, useState } from 'react';


Could you update this import to import * as React, then use React.useState etc? it's not enforced by ESLint yet but it's the style we try to apply everywhere for consistency

packages/core/admin/admin/src/components/FormInputs/Date.tsx

* feat: add content preview (remove future flag) * chore: fix tests * test(e2e): components and dz in create collection type (#22374) * feat(content-manager): add syntax highlighting in the code block type in the Blocks field original solution (#22332) * feat: install prismjs * feat(content-manager): add highlights to code block using Prismjs * feat(content-manager): remove screen debug * feat(content-manager): extends render leaf props * feat(content-manager): fix build issue * feat(content-manager): move prismjs theme import * feat(content-manager): change theme * feat(content-manager): theme import minimized * feat(content-manager): import prismjs types * feat(content-manager): change gh action config * feat(content-manager): revert the admin bundle size code * feat(content-manager): remove console log * feat(content-manager): change import theme * feat(content-manager): remove theme * feat(content-manager): change imports * feat(content-manager): change prismjs import * feat(content-manager): try to find the issue in gh action * feat(content-manager): add theme test * feat(content-manager): add packup css plugin * feat(content-manager): remove rollup * feat(content-manager): add change threshold * feat(content-manager): import Prism in Code component * feat(content-manager): remove prismjs * feat(content-manager): install prismjs * feat(content-manager): add prismjs theme * feat(content-manager): install prismjs in admin * feat(content-manager): try to change Prism import * feat(content-manager): add config file * feat(content-manager): add prismjs vite config * feat(content-manager): change rollup options * feat(content-manager): modify vite config * feat(content-manager): add manually prismjs * feat(content-manager): revert prismjs logic * feat(content-manager): fix build errors * feat(content-manager): solve failing fe unit tests * feat(content-manager): add threshold * feat(content-manager): fix import default * feat(content-manager): change vite config * feat(content-manager): add vite plugin prismjs * feat(content-manager): update vite config * feat(content-manager): fix issue decorate * chore: add prism in admin deps * feat(content-manager): replace original solution prismjs * feat(content-manager): remove useless prismjs dep in admin * feat(content-manager): change prismjs version * feat(content-manager): remove vite-plugin-prismjs * feat(content-manager): remove useless duplications in constants file * feat(content-manager): move some files * feat(content-manager): fix review comments * feat(content-manager): remove useless importPath property --------- Co-authored-by: Alexandre Bodin <bodin.alex@gmail.com> * chore(deps): bump nanoid from 3.3.7 to 3.3.8 in /docs (#22389) Bumps the npm_and_yarn group with 1 update in the /docs directory: [nanoid](https://github.com/ai/nanoid). Updates `nanoid` from 3.3.7 to 3.3.8 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * security(deps): bump nanoid to 3.3.8 in yarn.lock (#22397) * enhancement: update purchase page links (#22419) * enhancement: update purchase page links * chore: remove local tests * chore: add newline * enhancement(database): add repair manager with component deletion fix (#22267) * fix: preview back button behavior (#22432) * fix: multiple requests locale (#22273) * fix: multiple requests locale * fix: actions request * fix: properly load locales * fix: add status to localizations * fix: remove unused types * fix: front tests * fix: add validation fields into localizations * fix: validatable attributes * fix: select nested fields when populating localizations * fix: uncomment localizations populate * fix: document-metadata * fix: empty populate * fix: revert to original proposal * fix: do not select document ids on components (#22330) * fix: do not select document ids on components * chore: unit test * fix: metadata test * fix: populate * fix: default fields * fix: show current locale when bulk publishing * fix: create locale * Update packages/core/content-manager/server/src/services/document-metadata.ts Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com> --------- Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com> * fix: add component button style (#22425) * fix: add-component-button-style * fix: made it prettier * fix: optimizations * fix(blocks): various ui issues (#22423) * fix: blocks-ui-fixes * fix: made it prettier * fix: optimizations * fix: remove double conversion that causes date shift (#22410) * fix: remove double conversion that causes date shift * fix: remove useless files * release: 5.6.0 * Revert "release: 5.6.0" This reverts commit 77ad0ef. * release: 5.6.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rémi de Juvigny <remi.dejuvigny@strapi.io> Co-authored-by: Ben Irvin <ben.irvin@strapi.io> Co-authored-by: Rémi de Juvigny <8087692+remidej@users.noreply.github.com> Co-authored-by: Simone <startae14@gmail.com> Co-authored-by: Alexandre Bodin <bodin.alex@gmail.com> Co-authored-by: Convly <jean-sebastien.herbaux@epitech.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maxime Castres <17828745+Mcastres@users.noreply.github.com> Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com> Co-authored-by: Lucas Boilly <45385696+lucasboilly@users.noreply.github.com> Co-authored-by: Ziyi <ziyi.yuan@strapi.io>

* feat: add content preview (remove future flag) * chore: fix tests * test(e2e): components and dz in create collection type (#22374) * feat(content-manager): add syntax highlighting in the code block type in the Blocks field original solution (#22332) * feat: install prismjs * feat(content-manager): add highlights to code block using Prismjs * feat(content-manager): remove screen debug * feat(content-manager): extends render leaf props * feat(content-manager): fix build issue * feat(content-manager): move prismjs theme import * feat(content-manager): change theme * feat(content-manager): theme import minimized * feat(content-manager): import prismjs types * feat(content-manager): change gh action config * feat(content-manager): revert the admin bundle size code * feat(content-manager): remove console log * feat(content-manager): change import theme * feat(content-manager): remove theme * feat(content-manager): change imports * feat(content-manager): change prismjs import * feat(content-manager): try to find the issue in gh action * feat(content-manager): add theme test * feat(content-manager): add packup css plugin * feat(content-manager): remove rollup * feat(content-manager): add change threshold * feat(content-manager): import Prism in Code component * feat(content-manager): remove prismjs * feat(content-manager): install prismjs * feat(content-manager): add prismjs theme * feat(content-manager): install prismjs in admin * feat(content-manager): try to change Prism import * feat(content-manager): add config file * feat(content-manager): add prismjs vite config * feat(content-manager): change rollup options * feat(content-manager): modify vite config * feat(content-manager): add manually prismjs * feat(content-manager): revert prismjs logic * feat(content-manager): fix build errors * feat(content-manager): solve failing fe unit tests * feat(content-manager): add threshold * feat(content-manager): fix import default * feat(content-manager): change vite config * feat(content-manager): add vite plugin prismjs * feat(content-manager): update vite config * feat(content-manager): fix issue decorate * chore: add prism in admin deps * feat(content-manager): replace original solution prismjs * feat(content-manager): remove useless prismjs dep in admin * feat(content-manager): change prismjs version * feat(content-manager): remove vite-plugin-prismjs * feat(content-manager): remove useless duplications in constants file * feat(content-manager): move some files * feat(content-manager): fix review comments * feat(content-manager): remove useless importPath property --------- * chore(deps): bump nanoid from 3.3.7 to 3.3.8 in /docs (#22389) Bumps the npm_and_yarn group with 1 update in the /docs directory: [nanoid](https://github.com/ai/nanoid). Updates `nanoid` from 3.3.7 to 3.3.8 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect dependency-group: npm_and_yarn ... * security(deps): bump nanoid to 3.3.8 in yarn.lock (#22397) * enhancement: update purchase page links (#22419) * enhancement: update purchase page links * chore: remove local tests * chore: add newline * enhancement(database): add repair manager with component deletion fix (#22267) * fix: preview back button behavior (#22432) * fix: multiple requests locale (#22273) * fix: multiple requests locale * fix: actions request * fix: properly load locales * fix: add status to localizations * fix: remove unused types * fix: front tests * fix: add validation fields into localizations * fix: validatable attributes * fix: select nested fields when populating localizations * fix: uncomment localizations populate * fix: document-metadata * fix: empty populate * fix: revert to original proposal * fix: do not select document ids on components (#22330) * fix: do not select document ids on components * chore: unit test * fix: metadata test * fix: populate * fix: default fields * fix: show current locale when bulk publishing * fix: create locale * Update packages/core/content-manager/server/src/services/document-metadata.ts --------- * fix: add component button style (#22425) * fix: add-component-button-style * fix: made it prettier * fix: optimizations * fix(blocks): various ui issues (#22423) * fix: blocks-ui-fixes * fix: made it prettier * fix: optimizations * fix: remove double conversion that causes date shift (#22410) * fix: remove double conversion that causes date shift * fix: remove useless files * release: 5.6.0 * Revert "release: 5.6.0" This reverts commit 77ad0ef. * release: 5.6.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rémi de Juvigny <remi.dejuvigny@strapi.io> Co-authored-by: Ben Irvin <ben.irvin@strapi.io> Co-authored-by: Rémi de Juvigny <8087692+remidej@users.noreply.github.com> Co-authored-by: Simone <startae14@gmail.com> Co-authored-by: Alexandre Bodin <bodin.alex@gmail.com> Co-authored-by: Convly <jean-sebastien.herbaux@epitech.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maxime Castres <17828745+Mcastres@users.noreply.github.com> Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com> Co-authored-by: Lucas Boilly <45385696+lucasboilly@users.noreply.github.com> Co-authored-by: Ziyi <ziyi.yuan@strapi.io>

* fix: remove double conversion that causes date shift * fix: remove useless files

* feat: add content preview (remove future flag) * chore: fix tests * test(e2e): components and dz in create collection type (strapi#22374) * feat(content-manager): add syntax highlighting in the code block type in the Blocks field original solution (strapi#22332) * feat: install prismjs * feat(content-manager): add highlights to code block using Prismjs * feat(content-manager): remove screen debug * feat(content-manager): extends render leaf props * feat(content-manager): fix build issue * feat(content-manager): move prismjs theme import * feat(content-manager): change theme * feat(content-manager): theme import minimized * feat(content-manager): import prismjs types * feat(content-manager): change gh action config * feat(content-manager): revert the admin bundle size code * feat(content-manager): remove console log * feat(content-manager): change import theme * feat(content-manager): remove theme * feat(content-manager): change imports * feat(content-manager): change prismjs import * feat(content-manager): try to find the issue in gh action * feat(content-manager): add theme test * feat(content-manager): add packup css plugin * feat(content-manager): remove rollup * feat(content-manager): add change threshold * feat(content-manager): import Prism in Code component * feat(content-manager): remove prismjs * feat(content-manager): install prismjs * feat(content-manager): add prismjs theme * feat(content-manager): install prismjs in admin * feat(content-manager): try to change Prism import * feat(content-manager): add config file * feat(content-manager): add prismjs vite config * feat(content-manager): change rollup options * feat(content-manager): modify vite config * feat(content-manager): add manually prismjs * feat(content-manager): revert prismjs logic * feat(content-manager): fix build errors * feat(content-manager): solve failing fe unit tests * feat(content-manager): add threshold * feat(content-manager): fix import default * feat(content-manager): change vite config * feat(content-manager): add vite plugin prismjs * feat(content-manager): update vite config * feat(content-manager): fix issue decorate * chore: add prism in admin deps * feat(content-manager): replace original solution prismjs * feat(content-manager): remove useless prismjs dep in admin * feat(content-manager): change prismjs version * feat(content-manager): remove vite-plugin-prismjs * feat(content-manager): remove useless duplications in constants file * feat(content-manager): move some files * feat(content-manager): fix review comments * feat(content-manager): remove useless importPath property --------- * chore(deps): bump nanoid from 3.3.7 to 3.3.8 in /docs (strapi#22389) Bumps the npm_and_yarn group with 1 update in the /docs directory: [nanoid](https://github.com/ai/nanoid). Updates `nanoid` from 3.3.7 to 3.3.8 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect dependency-group: npm_and_yarn ... * security(deps): bump nanoid to 3.3.8 in yarn.lock (strapi#22397) * enhancement: update purchase page links (strapi#22419) * enhancement: update purchase page links * chore: remove local tests * chore: add newline * enhancement(database): add repair manager with component deletion fix (strapi#22267) * fix: preview back button behavior (strapi#22432) * fix: multiple requests locale (strapi#22273) * fix: multiple requests locale * fix: actions request * fix: properly load locales * fix: add status to localizations * fix: remove unused types * fix: front tests * fix: add validation fields into localizations * fix: validatable attributes * fix: select nested fields when populating localizations * fix: uncomment localizations populate * fix: document-metadata * fix: empty populate * fix: revert to original proposal * fix: do not select document ids on components (strapi#22330) * fix: do not select document ids on components * chore: unit test * fix: metadata test * fix: populate * fix: default fields * fix: show current locale when bulk publishing * fix: create locale * Update packages/core/content-manager/server/src/services/document-metadata.ts --------- * fix: add component button style (strapi#22425) * fix: add-component-button-style * fix: made it prettier * fix: optimizations * fix(blocks): various ui issues (strapi#22423) * fix: blocks-ui-fixes * fix: made it prettier * fix: optimizations * fix: remove double conversion that causes date shift (strapi#22410) * fix: remove double conversion that causes date shift * fix: remove useless files * release: 5.6.0 * Revert "release: 5.6.0" This reverts commit 77ad0ef. * release: 5.6.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rémi de Juvigny <remi.dejuvigny@strapi.io> Co-authored-by: Ben Irvin <ben.irvin@strapi.io> Co-authored-by: Rémi de Juvigny <8087692+remidej@users.noreply.github.com> Co-authored-by: Simone <startae14@gmail.com> Co-authored-by: Alexandre Bodin <bodin.alex@gmail.com> Co-authored-by: Convly <jean-sebastien.herbaux@epitech.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maxime Castres <17828745+Mcastres@users.noreply.github.com> Co-authored-by: Jamie Howard <48524071+jhoward1994@users.noreply.github.com> Co-authored-by: Lucas Boilly <45385696+lucasboilly@users.noreply.github.com> Co-authored-by: Ziyi <ziyi.yuan@strapi.io>

butcherZ added source: core:admin pr: fix labels Dec 12, 2024

butcherZ requested review from simotae14, remidej and Bassel17 December 12, 2024 19:18

remidej reviewed Dec 13, 2024

View reviewed changes

fix: remove double conversion that causes date shift

Loading
Loading status checks…

5376647

butcherZ force-pushed the fix/date-change-timezone branch from 97ba316 to 5376647 Compare December 13, 2024 09:43

butcherZ added the flag: don't merge label Dec 13, 2024

vercel bot deployed to Preview December 13, 2024 09:49 View deployment

fix: remove useless files

Loading
Loading status checks…

61dee3e

butcherZ requested a review from Marc-Roig December 17, 2024 14:20

vercel bot deployed to Preview December 17, 2024 14:25 View deployment

Marc-Roig approved these changes Dec 17, 2024

View reviewed changes

Marc-Roig removed the flag: don't merge label Dec 17, 2024

Marc-Roig merged commit e8d8fc8 into develop Dec 17, 2024
54 of 55 checks passed

Marc-Roig deleted the fix/date-change-timezone branch December 17, 2024 15:09

Marc-Roig mentioned this pull request Dec 18, 2024

Releases/5.6.0 (#22471) #22472

Merged

birdzai mentioned this pull request Dec 20, 2024

Date field picker displays incorrect date in content manager #22452

Closed

ulururu pushed a commit to ulururu/strapi that referenced this pull request Dec 23, 2024

fix: remove double conversion that causes date shift (strapi#22410)

39566dc

* fix: remove double conversion that causes date shift * fix: remove useless files

innerdvations mentioned this pull request Jan 9, 2025

Releases/5.7.0 (#22471) #22602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove double conversion that causes date shift #22410

fix: remove double conversion that causes date shift #22410

butcherZ commented Dec 12, 2024 •

edited by hanpaine

Loading

vercel bot commented Dec 12, 2024 •

edited

Loading

trunk-io bot commented Dec 12, 2024 •

edited

Loading

remidej Dec 13, 2024

		@@ -1,6 +1,5 @@
		import { forwardRef, memo } from 'react';
		import { forwardRef, memo, useState } from 'react';

fix: remove double conversion that causes date shift #22410

fix: remove double conversion that causes date shift #22410

Conversation

butcherZ commented Dec 12, 2024 • edited by hanpaine Loading

What does it do?

Why is it needed?

How to test it?

Related issue(s)/PR(s)

vercel bot commented Dec 12, 2024 • edited Loading

trunk-io bot commented Dec 12, 2024 • edited Loading

remidej Dec 13, 2024

Choose a reason for hiding this comment

butcherZ commented Dec 12, 2024 •

edited by hanpaine

Loading

vercel bot commented Dec 12, 2024 •

edited

Loading

trunk-io bot commented Dec 12, 2024 •

edited

Loading