fix: order when loading more than 10 relations #21855
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
added
source: core:content-manager
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marc-Roig
changed the title
remidej
reviewed
Oct 17, 2024
remidej
reviewed
Oct 17, 2024
|
will take a look! good catch |
|
@remidej I am not being able to replicate your issue (using the same content types and relation) , do you have any API error or cli error? |
remidej
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix loading more than 2 pages of relations in the content manager.
Relations are assigned a temp_key value based on their order (a0, a1, ..., z1, z2) . Each time a page was loaded the new temp keys were based from the first temp key of the list (a0), but that same value was used to compute the temp keys for the 3rd , ... pages. So the order was messed up.
How to test it?
Load more than 10 relations in a relational field.
Related issue(s)/PR(s)
Fixes #21808