-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix filters attribute name #21547
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@alexandrebodin @innerdvations @Convly I think this might be easier if we spend 15 minutes on discord discussing this ticket together 🤞 |
Agree, lots of things to say 😂 |
@Convly @alexandrebodin if we agree this is what we want to merge, could we have a last look and proceed with it? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like unit tests are failing, the rest lgtm
What does it do?
As seen in #21338 , attribute names called
filters
broke the populate validation.That's cause it was confusing a "filter" inside a populate with the filters attribute name:
The
traverseQueryPopulate
was assumingfilters
was an attribute, as it was an actual attribute of the schema. Hence the first query was always invalid.This PR solves this by modifying the
traverseQueryPopulate
and tracking each traversed node parent.