Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Export all files in Angular package.json #30849

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 18, 2025

Closes #30671

What I did

In #30250 we added a new exports field to package.json for angular and ember.
However angular imports dist files inside the package, which can not be found anymore.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-30849-sha-9c76d247. Try it out in a new sandbox by running npx storybook@0.0.0-pr-30849-sha-9c76d247 sandbox or in an existing project with npx storybook@0.0.0-pr-30849-sha-9c76d247 upgrade.

More information
Published version 0.0.0-pr-30849-sha-9c76d247
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/angular-exports
Commit 9c76d247
Datetime Tue Mar 18 15:07:07 UTC 2025 (1742310427)
Workflow run 13926620748

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30849

Greptile Summary

Updates the Angular framework package.json to export all files under the dist directory, improving package accessibility for consumers.

  • Modified exports field in code/frameworks/angular/package.json to use pattern './': './dist/'
  • Removed 'node' export condition from '.' and './node' exports for simplified access
  • Ensures all compiled files in dist directory are directly accessible to package consumers

Note: This is a focused change that improves package exports configuration without introducing breaking changes.

Sorry, something went wrong.

@kasperpeulen kasperpeulen added ci:merged Run the CI jobs that normally run when merged. bug labels Mar 18, 2025
Copy link

nx-cloud bot commented Mar 18, 2025

View your CI Pipeline Execution ↗ for commit 14ebed7.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 57s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-19 08:48:08 UTC

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 18, 2025
@kasperpeulen kasperpeulen force-pushed the kasper/angular-exports branch from 9c76d24 to 852432b Compare March 18, 2025 16:41
@kasperpeulen kasperpeulen changed the title Angular: Export all files under dist in Angular package.json Angular: Export all files in Angular package.json Mar 18, 2025
@kasperpeulen kasperpeulen requested a review from yannbf March 19, 2025 08:41
@kasperpeulen kasperpeulen merged commit 674fb8d into next Mar 19, 2025
66 of 67 checks passed
@kasperpeulen kasperpeulen deleted the kasper/angular-exports branch March 19, 2025 09:13
shilman pushed a commit that referenced this pull request Mar 22, 2025
Angular: Export all files in Angular package.json
(cherry picked from commit 674fb8d)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:merged Run the CI jobs that normally run when merged. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Internal server error: Missing "./dist/client/docs/config.js"
2 participants