Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Make sure that polyfills are loaded before the storybook is loaded #30811

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 14, 2025

Closes #

What I did

This PR removed the default zone.js polyfill because it was loaded twice:
#28657

However, the polyfills were loaded after the storybook preview entry is loaded, causing regressions.
For example, the XHR mock of storybook-addon-mock would execute with errors, because of a missing method:

ERROR TypeError: Illegal invocation
    at sr.ue [as scheduleFn] (68141.ddd3846e.iframe.bundle.js:1684:28318)
    at ir.scheduleTask (68141.ddd3846e.iframe.bundle.js:1684:7320)
    at Object.onScheduleTask (68141.ddd3846e.iframe.bundle.js:1684:4321)
    at ir.scheduleTask (68141.ddd3846e.iframe.bundle.js:1684:7211)
    at zt.scheduleTask (68141.ddd3846e.iframe.bundle.js:1684:3175)
    at zt.scheduleMacroTask (68141.ddd3846e.iframe.bundle.js:1684:3516)
    at L (68141.ddd3846e.iframe.bundle.js:1684:11263)
    at 68141.ddd3846e.iframe.bundle.js:1684:28819
    at Yt.zt.<computed> (68141.ddd3846e.iframe.bundle.js:1684:14770)
    at R._subscribe (68141.ddd3846e.iframe.bundle.js:34:25400)

Changing the order, fixes this.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Sorry, something went wrong.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@kasperpeulen kasperpeulen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:daily Run the CI jobs that normally run in the daily job. labels Mar 14, 2025
Copy link

nx-cloud bot commented Mar 14, 2025

View your CI Pipeline Execution ↗ for commit a59c35a.

Command Status Duration Result
nx affected -t check -c production --parallel=7 ✅ Succeeded 4s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-14 19:40:35 UTC

@kasperpeulen kasperpeulen merged commit 4d006e2 into next Mar 14, 2025
103 of 110 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-angular-polyfills branch March 14, 2025 21:48
shilman pushed a commit that referenced this pull request Mar 15, 2025
Angular: Make sure that polyfills are loaded before the storybook is loaded
(cherry picked from commit 4d006e2)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 15, 2025
@github-actions github-actions bot mentioned this pull request Mar 16, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant