Addon-Docs: Consider custom code snippet in story code panel and update styles #30179
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 1f21e81.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
larsrickert
force-pushed
the
larsrickert/code-panel-improvements
branch
from
2b41a51 to
1a656bc
Compare
larsrickert
changed the title
There was a problem hiding this comment.
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
larsrickert
force-pushed
the
larsrickert/code-panel-improvements
branch
from
686b102 to
5e1b8b9
Compare
larsrickert
force-pushed
the
larsrickert/code-panel-improvements
branch
from
5e1b8b9 to
1f21e81
Compare
shilman
changed the title
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
valentinpalkovic
changed the title
There was a problem hiding this comment.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| const parameter = useParameter(PARAM_KEY, { | ||
| source: { code: '' } as SourceParameters, | ||
| theme: 'dark', | ||
| }); |
There was a problem hiding this comment.
style: consider adding a default format to avoid potential undefined format issues when only code is provided
Follow up PR for #29253
What I did
useAddonStatewithuseStatebecause the code snippets are individual per story so persisting the state globally does not make sense / is not neededChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template react-vite/default-tsDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Enhanced code panel functionality in Storybook with improved custom code snippet handling and styling updates.
code/addons/docs/template/stories/codePanel/index.stories.tsxdemonstrating default, custom code, and panel-disabled statesuseAddonStatetouseStateincode/addons/docs/src/manager.tsxfor per-story code snippet managementSourceParameterstype exportable incode/lib/blocks/src/blocks/Source.tsxfor better type supportSourceStylescomponent💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!