Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Add theming/create aliases in docs preset #28570

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 12, 2024

What I did

CleanShot_2024-07-12_at_14 49 142x

This issue was reported, where @storybook/theming/create is used, but the alias breaks the import.
I extended the alias in docs preset to resolve this problem.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 25s 6.7s -18s -328ms 🔰-272.9%
generateTime 19.1s 23.8s 4.6s 🔺19.5%
initTime 19.3s 22.3s 2.9s 🔺13.4%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 0 B 0%
initSize 198 MB 198 MB 307 B 0%
diffSize 122 MB 122 MB 307 B 0%
buildTime 13.6s 13.9s 257ms 1.8%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 7s 9.1s 2s 🔺22.3%
devManagerResponsive 4.8s 6.2s 1.4s 🔺22.8%
devManagerHeaderVisible 707ms 815ms 108ms 🔺13.3%
devManagerIndexVisible 739ms 840ms 101ms 🔺12%
devStoryVisibleUncached 1.3s 925ms -395ms 🔰-42.7%
devStoryVisible 761ms 856ms 95ms 🔺11.1%
devAutodocsVisible 682ms 755ms 73ms 🔺9.7%
devMDXVisible 608ms 725ms 117ms 🔺16.1%
buildManagerHeaderVisible 668ms 805ms 137ms 🔺17%
buildManagerIndexVisible 670ms 814ms 144ms 🔺17.7%
buildStoryVisible 708ms 854ms 146ms 🔺17.1%
buildAutodocsVisible 612ms 682ms 70ms 🔺10.3%
buildMDXVisible 595ms 659ms 64ms 🔺9.7%

Sorry, something went wrong.

@ndelangen ndelangen self-assigned this Jul 12, 2024
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch theming ci:normal ci:docs Run the CI jobs for documentation checks only. labels Jul 12, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added alias for @storybook/theming/create in /code/addons/docs/src/preset.ts for webpack configuration
  • Added alias for @storybook/theming/create in /code/addons/docs/src/preset.ts for Vite configuration

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen requested review from JReinhold and shilman July 12, 2024 13:02
Copy link

nx-cloud bot commented Jul 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f9b105. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen added addon: docs and removed ci:docs Run the CI jobs for documentation checks only. labels Jul 12, 2024
@shilman shilman merged commit 5cb6c6e into next Jul 12, 2024
59 of 63 checks passed
@shilman shilman deleted the norbert/cpc-alias-for-theming-create branch July 12, 2024 14:30
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2024
…ing-create

CPC: Add `theming/create` aliases in docs preset
(cherry picked from commit 5cb6c6e)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants