Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add --config-dir flag to migrate command #26721

Merged
merged 1 commit into from Apr 3, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 3, 2024

Closes #

What I did

This PR adds a flag to the migrate so users can specify the config-dir of their Storybooks. This is mostly useful for the mdx-to-csf migration.

Checklist for Contributors

Testing

This was tested manually.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Run `path/to/cli/bin/index.js migrate --config-dir
  3. The command should not fail

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26721-sha-65e66987. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26721-sha-65e66987 sandbox or in an existing project with npx storybook@0.0.0-pr-26721-sha-65e66987 upgrade.

More information
Published version 0.0.0-pr-26721-sha-65e66987
Triggered by @ndelangen
Repository storybookjs/storybook
Branch yann/add-config-dir-flag-to-migrate
Commit 65e66987
Datetime Wed Apr 3 20:08:02 UTC 2024 (1712174882)
Workflow run 8544854995

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26721

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Apr 3, 2024
Copy link

nx-cloud bot commented Apr 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 65e6698. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit fbd2aaf into next Apr 3, 2024
55 of 61 checks passed
@yannbf yannbf deleted the yann/add-config-dir-flag-to-migrate branch April 3, 2024 09:13
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 3, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 4, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
storybook-bot pushed a commit that referenced this pull request Apr 5, 2024
…o-migrate

CLI: Add --config-dir flag to migrate command
(cherry picked from commit fbd2aaf)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants