Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve Yarn berry error parsing #26616

Merged
merged 1 commit into from Mar 22, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 22, 2024

Closes #

What I did

When having Yarn berry errors, most of the times the CLI doesn't provide anything helpful, just saying "Yarn2 error".
This PR changes the parsing logic so that it will show as much information as it can when extracting critical yarn errors (while trying to keep noise at a minimum level).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Please refer to the unit tests

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Mar 22, 2024
Copy link

nx-cloud bot commented Mar 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 48c3272. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf force-pushed the yann/improve-yarn2-error-messages branch from 83b6192 to 48c3272 Compare March 22, 2024 11:07
@yannbf yannbf merged commit ee7c4d9 into next Mar 22, 2024
57 of 61 checks passed
@yannbf yannbf deleted the yann/improve-yarn2-error-messages branch March 22, 2024 13:22
storybook-bot pushed a commit that referenced this pull request Mar 22, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 22, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 24, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…essages

CLI: Improve Yarn berry error parsing
(cherry picked from commit ee7c4d9)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants