Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport: Fix missing style #26530

Merged
merged 4 commits into from Mar 25, 2024
Merged

Conversation

jpzwarte
Copy link
Member

CleanShot 2024-03-16 at 17 37 39@2x

This adds a missing align-items: center to <ActiveViewportSize>. The result:
CleanShot 2024-03-16 at 17 39 32@2x

@jpzwarte jpzwarte added the bug label Mar 16, 2024
@jpzwarte jpzwarte changed the title Fix missing style in viewport addon Viewport: Fix missing style Mar 16, 2024
Copy link

nx-cloud bot commented Mar 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d64515. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@IanVS IanVS requested a review from cdedreuille March 18, 2024 11:47
Copy link
Contributor

@cdedreuille cdedreuille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JReinhold JReinhold added ui addon: viewport ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 22, 2024
@jonniebigodes jonniebigodes merged commit b071c44 into next Mar 25, 2024
55 of 61 checks passed
@jonniebigodes jonniebigodes deleted the fix/active-viewport-size-not-centered branch March 25, 2024 14:30
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
…ot-centered

Viewport: Fix missing style
(cherry picked from commit b071c44)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: viewport bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants