Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigFile: Fix export specifiers #25590

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 13, 2024

Closes N/A

What I did

Fixed another corner case for config file:

const parameters = { ... };
export { parameters };

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Use this pattern in preview.x or main.x in a sandbox.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch csf labels Jan 13, 2024
@shilman shilman requested a review from tmeasday January 13, 2024 06:50
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm not sure if that fixes the problem I ran into or not, but I'll assume it does!

@shilman shilman merged commit cb97367 into next Jan 16, 2024
57 of 58 checks passed
@shilman shilman deleted the shilman/fix-configfile-export-specifier branch January 16, 2024 08:24
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
storybook-bot pushed a commit that referenced this pull request Jan 16, 2024
…ort-specifier

ConfigFile: Fix export specifiers
(cherry picked from commit cb97367)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal csf patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants