UI: Fix infinite hook call causing browsers to freeze #24291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
ndelangen,
valentinpalkovic and
kasperpeulen
as code owners
central419
approved these changes
Sep 24, 2023
ndelangen
approved these changes
Sep 24, 2023
yannbf
force-pushed
the
yann/fix-infinite-effect-call
branch
2 times, most recently
from
0c783b7
to
4df967a
Compare
tmeasday
approved these changes
Sep 24, 2023
this was causing browsers to crash
yannbf
force-pushed
the
yann/fix-infinite-effect-call
branch
from
4df967a
to
09c793b
Compare
20 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 24, 2023
UI: Fix infinite hook call causing browsers to freeze (cherry picked from commit bf3c377)
Merged
3 tasks
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24275
What I did
Added a missing dependency to a useEffect hook which, by declaring no dependencies, was getting called infinitely. Thank you so much for spotting this out @eneaaliko0, you're the best!
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I was able to reproduce the issue in Mealdrop, and tested by getting the compiled output of the monorepo and pasting into Mealdrop's node_modules.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.馃 Canary release
This pull request has been released as version
0.0.0-pr-24291-sha-4df967a3. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-24291-sha-4df967a3yann/fix-infinite-effect-call4df967a31695573549)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24291