Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Remove console.log in sourceDecorator #24062

Merged
merged 2 commits into from Sep 4, 2023
Merged

Vue3: Remove console.log in sourceDecorator #24062

merged 2 commits into from Sep 4, 2023

Conversation

oruman
Copy link
Contributor

@oruman oruman commented Sep 4, 2023

When we use Vue3 in StoryBook in console always show parasite log for rendered.

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

When we use Vue3 in StoryBook in console always show parasite log for rendered.
@oruman oruman changed the title Remove parasite "console.log" sourceDecorator.ts [cleanup]: Remove parasite "console.log" sourceDecorator.ts Sep 4, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you so much for this contribution!

@yannbf yannbf changed the title [cleanup]: Remove parasite "console.log" sourceDecorator.ts Vue3: Remove console.log in sourceDecorator Sep 4, 2023
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 4, 2023
@oruman
Copy link
Contributor Author

oruman commented Sep 4, 2023

Thanks for Comunity and StoryBook.
Now I try creating addon for source Panel for story - it`s hard.

@yannbf yannbf merged commit a024424 into storybookjs:next Sep 4, 2023
44 of 45 checks passed
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
25 tasks
@oruman oruman deleted the patch-1 branch September 4, 2023 18:35
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
10 tasks
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
storybook-bot pushed a commit that referenced this pull request Sep 7, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Vue3: Remove console.log in sourceDecorator
(cherry picked from commit a024424)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants