Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add uncaughtException handler #24018

Merged
merged 1 commit into from Sep 1, 2023
Merged

CLI: Add uncaughtException handler #24018

merged 1 commit into from Sep 1, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 30, 2023

Closes #

What I did

We are commonly having issues that are caused by yarn 1 + hoisting. This PR adds an error handler at the earliest moment possible in the CLI, so we can advise users in known error scenarios such as the string-width issue.

  • Can telemetry be sent for such errors?
    No. This is the earliest moment in the code execution and it does not depend on any module imports, so the chance of some code breaking because of an unresolved/failed import (which is what string-width issue is about) is zero this way. If we tried to do more, the code could break before even registering the error handler.
  • Can we use the categorized errors here?
    No. Same reason as above

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Aug 30, 2023
@yannbf yannbf requested a review from shilman August 30, 2023 17:54
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yannbf yannbf merged commit a66b8b2 into next Sep 1, 2023
53 of 54 checks passed
@yannbf yannbf deleted the yann/string-width-issue branch September 1, 2023 16:49
storybook-bot pushed a commit that referenced this pull request Sep 1, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 1, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 1, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 4, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 7, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
CLI: Add uncaughtException handler
(cherry picked from commit a66b8b2)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants