Core: Fix indexing for non-prefixed stories.* stories
#23974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
ndelangen,
JReinhold and
tmeasday
as code owners
|
Self-merging @JReinhold |
Merged
11 tasks
Hypnosphi
reviewed
Aug 28, 2023
| @@ -196,7 +196,7 @@ export const features = async ( | |||
| }); | |||
|
|
|||
| export const csfIndexer: Indexer = { | |||
| test: /\.(stories|story)\.(m?js|ts)x?$/, | |||
| test: /(stories|story)\.(m?js|ts)x?$/, | |||
There was a problem hiding this comment.
we use *.examples.tsx naming convention in our project. Can we somehow override this regexp in our config?
There was a problem hiding this comment.
No. There's been talk about using the stories glob directly, but that's not implemented. Easiest thing is to use .stories.x per the documentation
There was a problem hiding this comment.
You could also add a custom indexer yourself. @JReinhold and @kylegach are working on docs for that
There was a problem hiding this comment.
yes @antrianis! The docs won't be published until the next minor version, but you can see it here: https://github.com/storybookjs/storybook/blob/next/docs/api/main-config-indexers.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23923
What I did
Add support for
(stories|story)\.*filesChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Add a
stories.tsfile to a sandbox馃 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>