Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix onboarding detection in what's new module #23424

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jul 12, 2023

Closes #

What I did

As title says

How to test

I have tested this, but here are the steps to do it yourself:

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser with the following urls:

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit 41973a7 into next Jul 13, 2023
73 of 75 checks passed
@kasperpeulen kasperpeulen deleted the fix/whats-new-onboarding-detection branch July 13, 2023 08:26
@github-actions github-actions bot mentioned this pull request Jul 13, 2023
15 tasks
@shilman shilman changed the title Core: Improve onboarding detection in what's new module Core: Fix onboarding detection in what's new module Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants