Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgsTable: Gracefully handle conditional args failures #18248

Merged
merged 1 commit into from May 18, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented May 18, 2022

Issue: #18177

self-merging @tmeasday

What I did

Swallow manager errors so that the UI doesn't crash when the user has specified an invalid condition.
Before the UI would whitescreen. Now:

image

How to test

Add an invalid conditional to any example, e.g.

  argTypes: {
    onClick: { action: 'click ', if: {} },
  }

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2948cae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 152e441 into next May 18, 2022
@shilman shilman deleted the 18177-fix-conditional-args-fail-gracefully branch May 18, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant