Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): Don't throw is Ctrl + C was pressed when selecting a package #18195

Merged
merged 1 commit into from May 16, 2022

Conversation

okonet
Copy link
Contributor

@okonet okonet commented May 11, 2022

Issue: N/A

What I did

This removes unhandled errors from CLI when Ctrl+C was pressed during package selection.

How to test

Run yarn build and when asked about what packages to run it on, press Ctrl+C. You should not see any error stack traces anymore.

Todo:

  • Do the same for bootstrap command.

@nx-cloud
Copy link

nx-cloud bot commented May 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab06f82. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added the maintenance User-facing maintenance tasks label May 11, 2022
@okonet okonet requested a review from ndelangen May 12, 2022 09:19
@okonet okonet marked this pull request as ready for review May 12, 2022 09:19
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @okonet thanks a lot for this contribution! Works great 🚀

@yannbf yannbf merged commit 44399d6 into next May 16, 2022
@yannbf yannbf deleted the fix-cli-throws branch May 16, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants