Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition: Fix metadata.json incorrectly overriding main.js refs versions #18185

Merged
merged 3 commits into from
May 10, 2022
Merged

Composition: Fix metadata.json incorrectly overriding main.js refs versions #18185

merged 3 commits into from
May 10, 2022

Commits on May 10, 2022

  1. when the loaded data from metadata.json contains an empty versions ob… 

    …ject, disregard it
    @ndelangen
    ndelangen committed May 10, 2022
    Configuration menu
    Copy the full SHA
    508fe11 View commit details
    Browse the repository at this point in the history

  2. always prefer user specified versions if set 

    It's assumed that if the user specified them, they intent to 'filter'.
    @ndelangen
    ndelangen committed May 10, 2022
    Configuration menu
    Copy the full SHA
    04f9388 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @ndelangen
    ndelangen committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1d7367e View commit details
    Browse the repository at this point in the history