security: update x-default-browser #18157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eb952ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
requested changes
May 6, 2022
There was a problem hiding this comment.
@The-Code-Monkey looks like you need to update the import in the source code as well
|
Of course, was rushed into a meeting thought I'd done it |
|
@shilman bump. |
|
This addresses a new audit warning introduced in this commit so would be great to see this brought in |
Codex-
reviewed
May 18, 2022
| declare module '@storybook/ui'; | ||
|
|
||
| declare module '@aw-web-design/x-default-browser'; | ||
| declare module '@storybook/ui'; |
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 19, 2022
security: update x-default-browser
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
created the package under my mono repo and published it with the security update, should work fine, i also converted all to typescript which means we don't need to declare any types
How to test
If your answer is yes to any of these, please make sure to include it in your PR.