Fixed PnP compatibility for bundled components package #18015
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9b0a59c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| @@ -21,11 +21,19 @@ interface Options { | |||
| watch?: boolean; | |||
| } | |||
|
|
|||
| const makeExternalPredicate = (externals: string[]) => { | |||
There was a problem hiding this comment.
This might matter for some packages so you don't end up bundling stuff like lodash/pickBy, because without a solution like this 'lodash' is treated as an external but all internal submodules are just bundled
| const makeExternalPredicate = (externals: string[]) => { | ||
| if (externals.length === 0) { | ||
| return () => false; | ||
| } | ||
| const pattern = new RegExp(`^(${externals.join('|')})($|/)`); | ||
| return (id: string) => pattern.test(id); | ||
| }; |
There was a problem hiding this comment.
this returns a fn?
I guess rollup supports this?
Why is this better?
There was a problem hiding this comment.
this returns a fn?
yes, this returns a predicate function testing if a particular import source should be treated as external or not
I guess rollup supports this?
yes
Why is this better?
#18015 (comment) , basically without this you have such a situation:
import _ from 'lodash' // treated as external
import pickBy from 'lodash/pickBy' // bundled in your scriptThe external match is exact so anything that you import using a "deep import" will be bundled (by default). This kind of predicate fixes the problem.
|
@ndelangen conflicts resolved |
hopefully, fixes #17978 caused by regression from #17947
util-deprecatehaspackage.json#browserqsdepends onobject-inspectand that package haspackage.json#browserWe can't bundle anything that has an alias field like that, such packages should always be external to leave the aliased stuff untouched for the consumers so they can resolve this on their own, based on the consuming environment.