CLI: Add addon-interactions to angular template #17437
Merged
+100
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16722
What I did
angular-changes.mov
A small thing I did not solve although I'd love to is this:
☝️ the buttons in the header don't have a space between them (it was already like that before). The reason for that is because we use a common css which has the following rule:
however in angular, the
button
elements are wrapped in astorybook-button
element from angular, so the css rule will never be applied:A solution would be to just add a
margin-left
css class to the buttons, this way it would work regardless of framework. This means making a small change but in every framework template, which I could do in another PR if y'all agree with the change!How to test
Checkout the branch
yarn build cli
run the cli
lib/cli/bin/index.js repro --framework angular
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.