Skip to content

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 6, 2021

Issue: #16253

What I did

Fix broken CRA4 upgrade

Self-merging @tmeasday

How to test

  • See attached tests
  • Run upgrade in a CRA4 project

Sorry, something went wrong.

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 6, 2021
@nx-cloud
Copy link

nx-cloud bot commented Oct 6, 2021

Nx Cloud Report

CI ran the following commands for commit b702708. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit d74aeb3 into next Oct 6, 2021
@shilman shilman deleted the 16253-fix-sb-upgrade-cra4 branch October 6, 2021 10:15
@shilman shilman added this to the 6.4 PRs milestone Oct 6, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 6, 2021
shilman added a commit that referenced this pull request Oct 6, 2021
CLI: Don't upgrade preset-create-react-app if react-scripts < 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant